[Dashboard] Fix ERC20 claim conditions #5284

kien-ngo · 2024-11-04T17:16:57Z

Fix various issues with ERC20 claim conditions since we up'd it to v5 on the dashboard

PR-Codex overview

This PR focuses on enhancing the handling of tokenDecimals for ERC20 tokens in the ClaimConditionsForm and related components, ensuring proper validation and conversion of values based on token type.

Detailed summary

Modified isDisabled properties in MaxClaimableSupplyInput and MaxClaimablePerWalletInput to account for tokenDecimals.
Updated ClaimConditionsForm to handle tokenDecimals as number | undefined.
Added checks for loading and existence of tokenDecimals.
Introduced conversion functions for ERC20 values to and from display format.
Adjusted logic in setClaimPhasesTx and getClaimPhasesInLegacyFormat to use tokenDecimals for ERC20 claims.
Improved error handling and user feedback when tokenDecimals cannot be fetched.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-11-04T17:16:58Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2024 5:37am

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Nov 6, 2024 5:37am
thirdweb_playground	⬜️ Skipped (Inspect)	Nov 6, 2024 5:37am
wallet-ui	⬜️ Skipped (Inspect)	Nov 6, 2024 5:37am

changeset-bot · 2024-11-04T17:17:01Z

⚠️ No Changeset found

Latest commit: d65387b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-11-04T17:17:03Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

kien-ngo · 2024-11-04T17:17:18Z

[Dashboard] Fix ERC20 claim conditions #5284 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite

github-actions · 2024-11-04T17:20:18Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	43 KB (0%)	861 ms (0%)	1.1 s (+112.19% 🔺)	1.9 s
thirdweb (cjs)	103 KB (0%)	2.1 s (0%)	1.2 s (+11.64% 🔺)	3.2 s
thirdweb (minimal + tree-shaking)	4.85 KB (0%)	97 ms (0%)	79 ms (+41.18% 🔺)	176 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	8 ms (-5.56% 🔽)	18 ms
thirdweb/react (minimal + tree-shaking)	17.51 KB (0%)	351 ms (0%)	143 ms (-3.02% 🔽)	493 ms

codecov · 2024-11-05T01:05:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.61%. Comparing base (418e3e4) to head (d65387b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5284   +/-   ##
=======================================
  Coverage   45.61%   45.61%           
=======================================
  Files        1068     1068           
  Lines       55556    55556           
  Branches     4047     4047           
=======================================
  Hits        25341    25341           
  Misses      29525    29525           
  Partials      690      690

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 418e3e4
packages	`40.72% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

joaquim-verges · 2024-11-05T01:52:43Z

...in)/[chain_id]/[contractAddress]/_components/claim-conditions/claim-conditions-form/hooks.ts

+    return "unlimited";
+  }
+  if (decimals) {
+    return toTokens(value, decimals);


why do you need this here? unlimited should be the same no matter the decimals no?

This is similar to toBigInt. While toBigInt converts the value to send it to the blockchain, toUnlimited converts the value from the blockchain to display it on the UI.

Without this new logic, a maxClaimableSupply of 100 tokens will be displayed on the frontend as: 100000000000000000000n

Updated the code pattern to make it similar to toBigInt

joaquim-verges · 2024-11-05T01:54:07Z

...in)/[chain_id]/[contractAddress]/_components/claim-conditions/claim-conditions-form/hooks.ts

+      // so we need to convert it using toUnits
+      maxClaimableSupply: toBigInt(
+        phase.maxClaimableSupply,
+        baseOptions.type === "erc20" ? baseOptions.decimals : undefined,


feels a bit confusing to bake this logic inside toBigInt - i think i would separate it at this level, and do an explicit to toUnits here instead

graphite-app · 2024-11-06T05:25:59Z

Merge activity

Nov 6, 12:25 AM EST: A user added this pull request to the Graphite merge queue.
Nov 6, 12:37 AM EST: A user merged this pull request with the Graphite merge queue.

Fix various issues with ERC20 claim conditions since we up'd it to v5 on the dashboard  --- ## PR-Codex overview This PR focuses on enhancing the handling of `tokenDecimals` for ERC20 tokens in the claim conditions form, ensuring that the application correctly manages and displays the maximum claimable supply and per wallet limits based on the token's decimal precision. ### Detailed summary - Updated `MaxClaimableSupplyInput` and `MaxClaimablePerWalletInput` to disable inputs if `tokenDecimals` is not available. - Changed `tokenDecimals` type from `number` to `number | undefined`. - Enhanced fetching logic for `tokenDecimals` in the claim conditions form. - Added error handling for missing `tokenDecimals` when submitting forms. - Introduced conversion functions for handling ERC20 values in wei and display format. - Updated `toBigInt` function to return `bigint | undefined`. - Adjusted `toUnlimited` function to maintain clarity on unlimited values. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – thirdweb_playground November 4, 2024 17:16 Inactive

vercel bot temporarily deployed to Preview – docs-v2 November 4, 2024 17:16 Inactive

vercel bot temporarily deployed to Preview – wallet-ui November 4, 2024 17:16 Inactive

github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 4, 2024

kien-ngo marked this pull request as ready for review November 4, 2024 17:17

kien-ngo requested review from MananTank, jnsdls and joaquim-verges as code owners November 4, 2024 17:17

kien-ngo self-assigned this Nov 4, 2024

vercel bot had a problem deploying to Preview – thirdweb-www November 4, 2024 17:44 Failure

kien-ngo added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Nov 4, 2024 — with Graphite App

kien-ngo marked this pull request as draft November 4, 2024 18:32

kien-ngo force-pushed the kien/fix-erc20-claim-condition branch from 7c07fda to 047c948 Compare November 5, 2024 01:01

vercel bot temporarily deployed to Preview – thirdweb_playground November 5, 2024 01:02 Inactive

vercel bot temporarily deployed to Preview – docs-v2 November 5, 2024 01:02 Inactive

vercel bot temporarily deployed to Preview – wallet-ui November 5, 2024 01:02 Inactive

kien-ngo force-pushed the kien/fix-erc20-claim-condition branch from 047c948 to 99c3a53 Compare November 5, 2024 01:03

vercel bot temporarily deployed to Preview – thirdweb_playground November 5, 2024 01:03 Inactive

vercel bot temporarily deployed to Preview – docs-v2 November 5, 2024 01:03 Inactive

vercel bot temporarily deployed to Preview – wallet-ui November 5, 2024 01:03 Inactive

kien-ngo force-pushed the kien/fix-erc20-claim-condition branch from 99c3a53 to 867f277 Compare November 5, 2024 01:14

vercel bot temporarily deployed to Preview – thirdweb_playground November 5, 2024 01:14 Inactive

vercel bot temporarily deployed to Preview – docs-v2 November 5, 2024 01:14 Inactive

vercel bot temporarily deployed to Preview – wallet-ui November 5, 2024 01:14 Inactive

kien-ngo marked this pull request as ready for review November 5, 2024 01:21

kien-ngo removed the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Nov 5, 2024

vercel bot deployed to Preview – thirdweb-www November 5, 2024 01:30 View deployment

kien-ngo force-pushed the kien/fix-erc20-claim-condition branch from 867f277 to 7f09c4b Compare November 5, 2024 01:41

vercel bot temporarily deployed to Preview – thirdweb_playground November 5, 2024 01:41 Inactive

vercel bot temporarily deployed to Preview – docs-v2 November 5, 2024 01:41 Inactive

vercel bot temporarily deployed to Preview – wallet-ui November 5, 2024 01:41 Inactive

joaquim-verges reviewed Nov 5, 2024

View reviewed changes

vercel bot deployed to Preview – thirdweb-www November 5, 2024 01:59 View deployment

kien-ngo force-pushed the kien/fix-erc20-claim-condition branch from 7f09c4b to 1f3ee9c Compare November 5, 2024 03:30

vercel bot temporarily deployed to Preview – wallet-ui November 5, 2024 03:30 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground November 5, 2024 03:30 Inactive

vercel bot temporarily deployed to Preview – docs-v2 November 5, 2024 03:30 Inactive

kien-ngo requested a review from joaquim-verges November 5, 2024 03:32

vercel bot deployed to Preview – thirdweb-www November 5, 2024 03:41 View deployment

joaquim-verges approved these changes Nov 6, 2024

View reviewed changes

kien-ngo force-pushed the kien/fix-erc20-claim-condition branch from 1f3ee9c to d65387b Compare November 6, 2024 05:26

vercel bot temporarily deployed to Preview – docs-v2 November 6, 2024 05:27 Inactive

vercel bot temporarily deployed to Preview – wallet-ui November 6, 2024 05:27 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground November 6, 2024 05:27 Inactive

vercel bot deployed to Preview – thirdweb-www November 6, 2024 05:37 View deployment

graphite-app bot merged commit d65387b into main Nov 6, 2024
32 checks passed

graphite-app bot deleted the kien/fix-erc20-claim-condition branch November 6, 2024 05:37

vercel bot temporarily deployed to Production – docs-v2 November 6, 2024 05:37 Inactive

vercel bot temporarily deployed to Production – wallet-ui November 6, 2024 05:37 Inactive

vercel bot temporarily deployed to Production – thirdweb_playground November 6, 2024 05:37 Inactive

vercel bot deployed to Production – thirdweb-www November 6, 2024 05:47 View deployment

[Dashboard] Fix ERC20 claim conditions #5284

[Dashboard] Fix ERC20 claim conditions #5284

Conversation

kien-ngo commented Nov 4, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Nov 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

kien-ngo commented Nov 4, 2024

Uh oh!

github-actions bot commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joaquim-verges Nov 5, 2024

Choose a reason for hiding this comment

Uh oh!

kien-ngo Nov 5, 2024

Choose a reason for hiding this comment

Uh oh!

kien-ngo Nov 5, 2024

Choose a reason for hiding this comment

Uh oh!

joaquim-verges Nov 5, 2024

Choose a reason for hiding this comment

Uh oh!

kien-ngo Nov 5, 2024

Choose a reason for hiding this comment

Uh oh!

kien-ngo Nov 5, 2024

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kien-ngo commented Nov 4, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Nov 4, 2024 •

edited

Loading

changeset-bot bot commented Nov 4, 2024 •

edited

Loading

github-actions bot commented Nov 4, 2024 •

edited

Loading

codecov bot commented Nov 5, 2024 •

edited

Loading

graphite-app bot commented Nov 6, 2024 •

edited

Loading